Presenter Console #10107
Open
Presenter Console #10107
+120
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hcvcastro
commented
Sep 24, 2024
hcvcastro
commented
- browser: slideshow: simplify notify blocked popup
- browser: slideshow: simplify 'onSlideShowInfo'
- browser: slideshow: add options parameter to SlideShowPresenter
- browser: slideshow: add options parameters to not start presentation
- browser: slideshow: change to public '_startSlide' access
- browser: slideshow: add 'PresenterConsole' class
- browser: slideshow: avoid unhandled excpetions requestedSlideHash
hcvcastro
force-pushed
the
pr/master/7C
branch
4 times, most recently
from
c675dc4
to
6761537
Compare
mcecchetti
reviewed
Sep 26, 2024
| this.addHooks(); | ||
| } | ||
|
|
||
| addHooks() { | ||
| addHooks() { | ||
| this._map.on('presentationinfo', this.onSlideShowInfo, this); | ||
| this._map.on('newfullscreen', this._onStart, this); |
There was a problem hiding this comment.
So, add this._map.off('presentationinfo', this.onSlideShowInfo, this) in removeHooks.
mcecchetti
reviewed
Sep 26, 2024
| @@ -81,12 +81,14 @@ abstract class AnimationBaseNode extends BaseNode { | |||
| slideHash, | |||
| slideWidth, | |||
| slideHeight, | |||
| this.aNodeContext.metaSlide._slideShowHandler.getPresenter()._slideRenderer | |||
| ) | |||
There was a problem hiding this comment.
you can access _SlideShowHandler through this.aNodeContext.aContext.aSlideShowHandler
mcecchetti
reviewed
Sep 26, 2024
| ) | ||
| : new AnimatedElement( | ||
| this.aTargetHash, | ||
| slideHash, | ||
| slideWidth, | ||
| slideHeight, | ||
| this.aNodeContext.metaSlide._slideShowHandler.getPresenter()._slideRenderer | ||
| ); |
mcecchetti
reviewed
Sep 26, 2024
| @@ -15,7 +15,7 @@ declare var app: any; | |||
| class MetaSlide { | |||
| private _info: SlideInfo; | |||
| private readonly _metaPres: MetaPresentation; | |||
| private readonly _slideShowHandler: SlideShowHandler; | |||
| public readonly _slideShowHandler: SlideShowHandler; | |||
| private _transitionHandler: SlideTransition; | |||
There was a problem hiding this comment.
no need, see comment in AnimationBaseNode
mcecchetti
reviewed
Sep 26, 2024
| @@ -110,7 +110,8 @@ class SlideShowPresenter { | |||
| _slideShowCanvas: HTMLCanvasElement = null; | |||
| _slideShowWindowProxy: ReturnType<typeof window.open> = null; | |||
| _windowCloseInterval: ReturnType<typeof setInterval> = null; | |||
| _currentSlide: number = 0; | |||
| _currentSlide: number = 0; | |||
| _startSlide: number; | |||
There was a problem hiding this comment.
FYI: _currentSlide will probably be removed; for known the current slide index ask SlideShowNavigator
mcecchetti
reviewed
Sep 26, 2024
| @@ -621,6 +621,10 @@ class LayerDrawing { | |||
| this.prefetchedSlideHash = null; | |||
| return; | |||
| } | |||
|
|
|||
| if (!this.requestedSlideHash) | |||
| return; | |||
There was a problem hiding this comment.
in case better to log a warning on the console
hcvcastro
force-pushed
the
pr/master/7C
branch
from
6761537
to
84594e7
Compare
Useful with 2 instances of SlideShowPresenter class. Change-Id: I5b02830286f4c2dedae8daf90a8758e70c836e50 Signed-off-by: Henry Castro <[email protected]>
Useful with 2 instances of SlideShowPresenter class. Change-Id: I5e11bd26c2155e5ab40715a9697e22ea32b5ab1d Signed-off-by: Henry Castro <[email protected]>
Useful with 2 instances of SlideShowPresenter class. Change-Id: Ie3329746cd6f2b7a83c1ee9054db226f8d1b8b15 Signed-off-by: Henry Castro <[email protected]>
Useful with 2 instances of SlideShowPresenter class. Change-Id: Ibe39c8f907544eca134348d0ac77095cfffb964e Signed-off-by: Henry Castro <[email protected]>
Change-Id: Ibd4017174bd9eff5ffe456847cb3e4287ccaeba2 Signed-off-by: Henry Castro <[email protected]>
Change-Id: Ibb07c214afe2741942e2f81281395077328eab63 Signed-off-by: Henry Castro <[email protected]>
Useful with 2 instances of SlideShowPresenter class Change-Id: I1e0528d05ddfc157350e7aa549223638c2aa24b9 Signed-off-by: Henry Castro <[email protected]>
Useful with 2 instances of SlideShowPresenter class. Change-Id: Ic162190f881e3a32395afd45fa84e8e81fecf084 Signed-off-by: Henry Castro <[email protected]>
Useful with 2 instances of SlideShowPresenter class. Change-Id: I27c301cb7dfdae9034df97eed107a2066cadc84a Signed-off-by: Henry Castro <[email protected]>
Change-Id: I9e07681b3834e35b673e65e126fe751f3060403b Signed-off-by: Henry Castro <[email protected]>
It removes all cached master page layers so the background layer is lost when the start slide is greater than 0. Change-Id: I4ce3b40f80fc6e8f268b6528db501e209ea8dcb3 Signed-off-by: Henry Castro <[email protected]>
hcvcastro
force-pushed
the
pr/master/7C
branch
from
84594e7
to
04b037e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.