-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private/codewithvk/webgl canvas load layer #10114
Conversation
a02ee26
to
67b531b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. To try it locally.
While testing it I found the following issues:
I reported more details on the related task page |
I implemented a patch (#10153) that renders each animation frame directly in the gl canvas provided by |
As we are using offscreen GL canvas performance often depends on the device you are using. TBH it's a bit faster for my device not sure why it's slow for you. Maybe we can discuss and stick to 2d canvas if we want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the last commit performances are improved. It's fine to merge for me.
Signed-off-by: codewithvk <[email protected]> Change-Id: I8068f18cd686ac976f6a64b4d3b4b725eb6fd717
Signed-off-by: codewithvk <[email protected]> Change-Id: If25ed9ae712365a7ac3a3066e804f00f46fde4bf
Signed-off-by: codewithvk <[email protected]> Change-Id: I3e84d096a2f8cd386a43190931898110cc29f466
Signed-off-by: codewithvk <[email protected]> Change-Id: Ia236004c02516c5e491174d172204479b8567b6c
3f1f51c
to
62fee6b
Compare
Signed-off-by: codewithvk <[email protected]> Change-Id: I3cd2363687bfe8e8d054830efce366890c5d5e7c
62fee6b
to
dbbda52
Compare
Summary
TODO
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay