Make Styles preview box width flexible #10132
Conversation
|
2 cypress specs are failing ✖ writer/table_operation_spec.js ✖ writer/top_toolbar_spec.js probably because we are relying on a x amount of clicks in the scroll indicator... I need to check those. Probably best if for those we just scroll horizontally until the scroll indicator is not visible. Or maybe safer to just adjust the number of clicks according to the cypress resolution settings (that way it will not impact any next steps in the test) |
|
writer/table_operation_spec.js ✖ writer/top_toolbar_spec.js They are unrelated.. Top toolbar passes now and writer/table_operation_spec.js.. I just had time to re-check this... and these failed tests are not related to this PR. It fails in the trying to check an attribute in the #copy-paster-container |
Resolves Styles preview box width depand on window size #2210 No need to set hard coded width. Better to set it to a portion of the viewport's width. Also make sure the grid is tidier by actually using a grid and not inline-flex and setting the proper width and height of each cell. Note if more buttons are added to the Home tab then that 35vw should be updated accordingly Signed-off-by: Pedro Pinto Silva <[email protected]> Change-Id: Ifd8696caf0d9b49fcb2c6929ea5f23505d7cff42
pedropintosilva
force-pushed
the
private/pedro/gh#2210
branch
2 times, most recently
from
67ae644
to
b0c57fb
Compare
Now Stylesview's width is flexible and thus this test needs to be updated to reflect that. Signed-off-by: Pedro Pinto Silva <[email protected]> Change-Id: I13198625e8f122104f2ef587187bb3c6c1ad9407
pedropintosilva
force-pushed
the
private/pedro/gh#2210
branch
from
b0c57fb
to
089b351
Compare
Resolves Styles preview box width depand on window size #2210
No need to set hard coded width. Better to set it to a portion of the
viewport's width. Also make sure the grid is tidier by actually using
a grid and not inline-flex and setting the proper width and height
of each cell.
Note if more buttons are added to the Home tab then that 35vw should
be updated accordingly
Signed-off-by: Pedro Pinto Silva [email protected]
Change-Id: Ifd8696caf0d9b49fcb2c6929ea5f23505d7cff42