Added new addressinputfiled jsdialog #10134
Open
+266
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Sep 26, 2024
eszkadev
reviewed
Sep 26, 2024
- this is primarily done to have ability to add named ranges from address input field and select different named ranges through address input field - updates regarding named ranges etc comes from core Signed-off-by: Rashesh <[email protected]> Change-Id: Ieb8dd956b57c4359fa5c86055a0e201842a9696b
- removes onUpdatePermission method as it is not required we don't show addressinput field anyway in the readonly mode - rename input selector: "#addressInput-input" -> "#addressInput input" Signed-off-by: Rashesh <[email protected]> Change-Id: Ica2a6f9ca6e0ac1c5b7348573649a5033f9894db
- addressinputfield message is too early before we have component initialized on client side Signed-off-by: Rashesh <[email protected]> Change-Id: I3def3f35150b503a90aae25beed19c01bb8c5b86
Rash419
force-pushed
the
calc-name-range-fix
branch
from
9f5dd73
to
8646f1a
Compare
Signed-off-by: Rashesh <[email protected]> Change-Id: I111298ea12d668f5dc9aa4dea8e859b840acbb37
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Rashesh <[email protected]> Change-Id: I4fdfb191facf35804cfda20f434a3ede6544eb2e
Rash419
force-pushed
the
calc-name-range-fix
branch
from
a137b87
to
05b2333
Compare
eszkadev
reviewed
Sep 27, 2024
- add 'changeOnEnterOnly' property to the json Signed-off-by: Rashesh <[email protected]> Change-Id: Id91dc05a3be8e22d205f9017c977fbe8991e1aae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: https://gerrit.libreoffice.org/c/core/+/173987