Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cool#9992 doc sign: fix missing enable on the cert chooser description entry #10135

Merged
merged 3 commits into from
Oct 1, 2024

Commits on Sep 30, 2024

  1. cool#9992 doc sign: fix missing enable on the cert chooser descriptio…

    …n entry
    
    Open the signatures dialog, add a signature, the certificate chooser
    sub-dialog appears. Select a certificate, that enables e.g. the sign
    button, but not the description input field for some reason.
    
    Checking the websocket incoming traffic, the message for the working
    button and the broken entry is the same:
    jsdialog: { "jsontype": "dialog", "action": "action", "id": 10, "data": { "control_id": "viewcert", "action_type": "enable"}}
    jsdialog: { "jsontype": "dialog", "action": "action", "id": 10, "data": { "control_id": "description", "action_type": "enable"}}
    But the DOM is different:
    <button class="ui-pushbutton jsdialog" id="viewcert" accesskey="V" disabled tabindex="0"><u class="access-key">V</u>iew Certificate</button>
    <div class="ui-edit-container jsdialog" id="description" tabindex="0"><input class="ui-edit jsdialog" id="description-input" dir="auto" disabled></div>
    
    Fix the problem similar to what commit
    0d4e4af (jsdialog: find real input on
    setText action, 2022-08-24) did for the setText action type: if there is
    a child input element, work with that instead.
    
    Probably doing so for the disable case would also make sense, but I this
    dialog never disables input fields, so leave that alone for now.
    
    Signed-off-by: Miklos Vajna <[email protected]>
    Change-Id: I94a9a3c5fd846be86a5db175ce93ffff136881de
    vmiklos committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    de0c1ab View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. jsdialog: fix input field enable action

    so JSDialog.SynchronizeDisabledState will work correctly
    this is followup for commit 3591fba
    Fix state update of input element
    
    Signed-off-by: Szymon Kłos <[email protected]>
    Change-Id: Idba598a67454933f7192039e55cc592270a5e63d
    eszkadev authored and vmiklos committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    515376a View commit details
    Browse the repository at this point in the history
  2. cool#9992 doc sign: better fix for the cert chooser dialog's disabled…

    … description widget
    
    Set 'disabled' on the container as well, then the
    JSDialog.SynchronizeDisabledState code will enable the inner 'input'
    element when the container gets enabled.
    
    Signed-off-by: Miklos Vajna <[email protected]>
    Change-Id: I1733a5493b53fabd9f2278a5005c33f01905742e
    vmiklos committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3146355 View commit details
    Browse the repository at this point in the history