Private/caolan/can elide a dns lookup #10138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolan/can_elide_a_dns_lookup
branch
2 times, most recently
from
2b173db
to
9d03c3b
Compare
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I08aae7fcafa68cfb3fc90fb418375b0bd95458a9
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I22cbcec530bb8defd7b3d0f71689d47a7ea60206
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I30bee69e9960fa4f67c81e3d4d67ea6b227d73fc
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I56a0c217928d96298e763fa974cfc976ffa0bc02
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Id679fc366126ec49583c40887e6450ea5d123d22
so we don't have to fetch it again later at SSL verification time. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Iadfb3918cbedf67393eaeb6d8ba5f94cb6c4c27b
caolanm
force-pushed
the
private/caolan/can_elide_a_dns_lookup
branch
from
9d03c3b
to
9e0c51f
Compare
|
My thought here here is that the only (non-testing) place where we create a StreamSockets with a hostname is where we have just retrieved the DNS info in order to connect. Later in verifyCertificate, which will basically nearly always get called, we check if that hostname is for the localhost or not, and end up doing another DNS query to find that out. We could elide that (currently sync) 2nd DNS query if we just determine that during the 1st DNS query at ctor time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay