Fix regression in Socket::shutdown() when having _noShutdown set
#10298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, saw usage at the paired sockets but was unsure about semantics. |
Regression injected with commit 0579ee8 of PR #9916 Original behavior was to do nothing in Socket::shutdown(), while the commit in question did setClosed() leading to an eventual socket close within SocketPoll::poll(). The latter causes an error within system ::ppoll(). Signed-off-by: Sven Göthel <[email protected]> Change-Id: I57d46e0428905137e05d34dad450fea1d6a0f127
caolanm
force-pushed
the
private/sgothel/regression_socket_shutdown
branch
from
1aab56e
to
e5d86f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I57d46e0428905137e05d34dad450fea1d6a0f127
Summary
Regression injected with commit 0579ee8 of PR #9916
Original behavior was to do nothing in Socket::shutdown(), while the commit in question did setClosed() leading to an eventual socket close within SocketPoll::poll().
The latter causes an error within system ::ppoll().
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay