-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContextMenu: add a css class to entries #10351
base: master
Are you sure you want to change the base?
Conversation
There is the |
Hiding say "Insert Comment" context menu entry can be achieved with CSS: li:has(.insert-comment) + li.context-menu-separator {
/* hide the next separator /*
display: none;
}
li:has(.insert-comment)
{
/* hides the line that has the insert-comment action */
display: none;
} |
In |
the |
The itemName here is not an uno command but some descriptive text from translation: I could work with the uno-command, and use then the "insert-annotation" class instead. It would be consistent with the rest of the logic. This function reuses same entries for different actions, I don't think it matches well my need:
Since |
Signed-off-by: Méven Car <[email protected]> Change-Id: I71ce81efcbbb0c6a57d808d5f5d0e691567dfad5
087fc77
to
c3d00e3
Compare
Updated to use the more stable uno command as class, i.e InsertAnnotation => insert-annotation |
LGTM but I think this should have a ack from someone on the dev team. |
multiple asserts failing https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/2211/consoleFull but all of them seem unrelated (Calc: address input or calc paste). Pressing retry |
Change-Id: I71ce81efcbbb0c6a57d808d5f5d0e691567dfad5
Summary
Adds class names to context menus entries, so they can be tweaked through CSS
Checklist
make prettier-write
and formatted the code.make run
and manually verified that everything looks okay