Implement MaxConnection Limit (2) #10370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
from
7031ce0
to
80b7531
Compare
|
Forced pushed (no1): |
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
from
80b7531
to
b0ee7ea
Compare
5 tasks
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
from
b0ee7ea
to
56afaf1
Compare
|
Forced pushed (no2): Moved limit-check/registration to StreamSocket::create() |
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
2 times, most recently
from
826374c
to
013278f
Compare
mmeeks
requested changes
Oct 30, 2024
|
Would be nice to get the base commits in and re-base this of course too =) I queued another build. |
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
2 times, most recently
from
136e95a
to
631db5f
Compare
|
Great - hopefully we can re-base as-is on whatever fixes are going in for CI |
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
from
631db5f
to
5743363
Compare
|
Small fix force pushed, detected with subsumed PR ... (missed this config case) |
caolanm
force-pushed
the
private/sgothel/socketcode_maxconn
branch
from
5743363
to
4a4bff4
Compare
added 2 commits
November 1, 2024 11:32
This reverts commit 80246f7. Signed-off-by: Sven Göthel <[email protected]> Change-Id: Ib9f0ac17c05ffe65c2370490f68f581fa76730e7
Reimplementation of commit 80246f7 (post revert). Adding external TCP connection limit to server-side TCP IPv4/IPv6 Sockets - Counted at StreamSocket ctor - Only limits TCP connections for server-side IPv4 or IPv6 TCP connections. - Rejected at ServerSocker::handlePoll - If exceeding net::Defaults.maxExtConnections, socket object and hence connection is dropped net::Defaults - Renamed maxTCPConnections -> maxExtConnections TODO: - revise net::Defaults.maxExtConnections to match actual system settings Signed-off-by: Sven Göthel <[email protected]> Change-Id: Ib9f0ac17c05ffe65c2370490f68f581fa76730e7
sgothel
force-pushed
the
private/sgothel/socketcode_maxconn
branch
from
4a4bff4
to
57f6414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #10366 !
Summary
Reimplementation of commit 80246f7 (post revert).
Adding external TCP connection limit to server-side TCP IPv4/IPv6 Sockets
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay