Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable context menu key #10473

Merged

Conversation

codewithvk
Copy link
Contributor

@codewithvk codewithvk commented Nov 12, 2024

Cherry-pick two commits from: #9825

Core side patch : https://gerrit.libreoffice.org/c/core/+/171914

NickWingate and others added 3 commits November 12, 2024 23:32
Allows keyboard navigation of context menu

Signed-off-by: NickWingate <[email protected]>
Change-Id: I1eeb0afa7447c42f60f86ce42e152ad3d65c6e58
When context menu key is pressed we now send the command
to core.

Signed-off-by: NickWingate <[email protected]>
Change-Id: Ic12c5f3837042556962fb563107d34a6c0c374a6
…popup

Signed-off-by: codewithvk <[email protected]>
Change-Id: I43293ae1c3f337d51767850260114352491b1aaa
@codewithvk codewithvk marked this pull request as ready for review November 13, 2024 08:43
@codewithvk codewithvk mentioned this pull request Nov 13, 2024
6 tasks
@eszkadev
Copy link
Contributor

Thanks for improvement, at first look seems to work. I noticed that we always trigger context menu for the "CELL" in calc, even if we selected part of the text inside EDIT mode. Might be good improvment in the followup.

contextmenu-2024-11-13_11.04.24.webm

Copy link
Contributor

@pedropintosilva pedropintosilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedropintosilva pedropintosilva merged commit 017e293 into CollaboraOnline:master Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Menu key should trigger right click menu
4 participants