Skip to content

Conversation

rparth07
Copy link
Contributor

@rparth07 rparth07 commented Sep 21, 2025

Change-Id: I2f999f135118dc8ab7015fe97aae9de6cf8de6b8

Core changes requires: https://gerrit.libreoffice.org/c/core/+/191289

Changes:

  1. Introduced new param InitialFocusReplace for .uno:SearchDialog to enable initial focus on replace tab when,
    1. Click on Replace button
    2. Use Ctrl + H shortcut

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Parth Raiyani <[email protected]>
Change-Id: I2f999f135118dc8ab7015fe97aae9de6cf8de6b8
@rparth07 rparth07 force-pushed the private/rparth07/search-dialog-initial-focus-param branch from 27c45f2 to 145561b Compare September 22, 2025 05:05
Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!
can we have cypress test for it? just press ctrl+h and expect replace tab will be opened

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Sep 25, 2025
@eszkadev eszkadev merged commit a901d4b into master Sep 25, 2025
14 checks passed
@eszkadev eszkadev deleted the private/rparth07/search-dialog-initial-focus-param branch September 25, 2025 07:28
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants