Detach navigator from sidebar #9933
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NickWingate <[email protected]> Change-Id: Iba2142d44f29ad0eb9293859f45c0718d3a223b4
Signed-off-by: NickWingate <[email protected]> Change-Id: Ic1ee078dca4792b314e5f9a835ae50a79ab7ee62
Signed-off-by: NickWingate <[email protected]> Change-Id: Ia09748abcec00a75b8743778907d5ede28c6720b
Responsible for handling and rendering events related to the navigator Signed-off-by: NickWingate <[email protected]> Change-Id: I1bd3718f1cd3ab4e46e6354166267376013588a8
eszkadev
reviewed
Sep 13, 2024
| */ | ||
|
|
||
| /* global app */ | ||
| class NavigatorPanel { |
There was a problem hiding this comment.
Can we now create base class: SidebarBase which will be parent of Sidebar and Navigator.
We can then share almost all of the onAdd, onRemove, isVisible, onJSUpdate, onJSAction.
We only need to define strings which are different:
this.commandId = 'navigator' / 'sidebar';
this.containerWrapperId = 'navigator-dock-wrapper' / 'siebar-dock-wrapper';
this.panelId = 'navigator-panel' / 'sidebar-panel';
why do not concatenate even more: TYPE + '-dock-wrapper' ? because it's then easier to git grep if id is fully present in the code and css to find related code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay