browser: accessibility: fix min-content, max-content grid #9944
Conversation
hcvcastro
force-pushed
the
pr/master/7B
branch
2 times, most recently
from
4005616
to
3c65582
Compare
Change-Id: I8a4615ef0c2abdd21d57737708d64a4c79cc134f Signed-off-by: Henry Castro <[email protected]>
Darshan-upadhyay1110
requested review from
pedropintosilva and
eszkadev
and removed request for
pedropintosilva
|
Hi @hcvcastro , can we have description in the commit message what does that fix? |
| @@ -308,7 +308,7 @@ td.jsdialog > [id^='table-box']:not(.sidebar) { | |||
| } | |||
|
|
|||
| .ui-tabs-content.jsdialog > .ui-content.hidden { | |||
| display: inherit !important; | |||
| display: none !important; | |||
There was a problem hiding this comment.
visibility: hidden causes element to be hidden but still occupying the space
display: none removes the element completely
This is important inside grids where we have specific order of columns and rows
There was a problem hiding this comment.
we did that to keep the same size of every tab in the dialog so "Next" button in the wizard will be at the same place, so user can just click multiple times in the same place
|
We decided in the past that dialog should keep the same size when switching tabs if possible. It is important to keep "ok", "cancel" button at the same position on the screen. dynamicsize-2024-09-23_08.22.18.webm |
|
Before it was like this: dynamicsize-2024-09-23_08.27.20.webm |
Change-Id: I8a4615ef0c2abdd21d57737708d64a4c79cc134f
Signed-off-by: Henry Castro [email protected]