Bring 1.83.x branch to main #719
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we love to live dangor-ously
Co-authored-by: Kemal Setya Adhi <[email protected]>
All entries except Primitives.Popup since it requires DataTriggerBehavior
Always disable optimization while calling CurrentToastNotificationService to avoid weird NRE due to over-optimization on JIT before compilation
+ Since the AOT build is pretty much stable now (thanks to .NET 9.0.2 patch), we are going to set the optimization preference back to Speed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return false; | ||
| } | ||
|
|
||
| ResourceRecordCollection CreateFromSingle(string host, byte[] addressByte) |
Check warning
Code scanning / QDNET
Variable in local function hides variable from outer scope Warning
| return; | ||
| } | ||
|
|
||
| LauncherConfig.SetAndSaveConfigValue("IsUseExternalDns", (_isUseExternalDns = value) ?? false); |
Check warning
Code scanning / QDNET
'??' condition is known to be null or not null Warning
100% reviewed source file: 'en_US.json' on 'id_ID'.
97% of minimum 75% reviewed source file: 'en_US.json' on 'es_419'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
100% reviewed source file: 'en_US.json' on 'zh_CN'.
84% of minimum 75% reviewed source file: 'en_US.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
100% reviewed source file: 'en_US.json' on 'ja_JP'.
97% of minimum 75% reviewed source file: 'en_US.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
90% of minimum 75% reviewed source file: 'en_US.json' on 'uk_UA'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
86% of minimum 75% reviewed source file: 'en_US.json' on 'ru_RU'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
94% of minimum 75% reviewed source file: 'en_US.json' on 'ko_KR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
97% of minimum 75% reviewed source file: 'en_US.json' on 'vi_VN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
100% reviewed source file: 'en_US.json' on 'es_419'.
100% reviewed source file: 'en_US.json' on 'fr_FR'.
100% reviewed source file: 'en_US.json' on 'ja_JP'.
Apply nullable on all the to be disposed objects fix #721
| private Brush? BackgroundHighlightSelectedBrush { get; } | ||
| private Brush? BackgroundOriginalBrush { get; } | ||
|
|
||
| internal IList<TextHighlighter>? ElementTextHighlighter { get; } |
Check warning
Code scanning / QDNET
Auto-property accessor is never used (non-private accessibility) Warning
| using Microsoft.UI.Xaml.Input; | ||
| using Microsoft.UI.Xaml.Media; | ||
| using Microsoft.UI.Xaml.Media.Animation; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Collections.ObjectModel; | ||
| using System.ComponentModel; |
Check warning
Code scanning / QDNET
Redundant using directive Warning
100% reviewed source file: 'en_US.json' on 'zh_CN'.
100% reviewed source file: 'en_US.json' on 'es_419'.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features Spotlight: (so far)
(2nd try) NativeAOT Releases!
More native-app like speed in terms of start-up and other resource heavy operations (such as installation and repair). This is our 2nd try on shipping NativeAOT builds due to .NET issue back in SDK 9.0.0 causing random freeze/crashes. Let us know how you feel about Collapse performance and stability on this release!
External DNS Support, by @neon-nyan
Ability to set the DNS request to specific server just for the launcher. Supports plain DNS (UDP/53), DNS over HTTPS (DoH), and DNS over TLS (DoT). Includes 3 predefined DNS providers, Cloudflare (
$cloudflare), Google ($google), and quad9 ($quad9). User can customize to use other DNS provider(s) and use multiple all at once as a fallback.Search on App Settings, by @bagusnl & @neon-nyan
Tired of scrolling all of our launcher MASSIVE tunable options? Us too! That's why we have implemented a way to search all the available settings by just typing it, then you can navigate by using arrows to get to the settings you want. Works in all of our supported locales!
Sophon Patch for Game Update Implementation, by @neon-nyan
HoYo recently released what we called "Sophon Patch Mode" for game update. This method is different than the older "Sophon Chunk" as the patch method compares the entire file instead of replacing part of the file like in chunk method. This leads to Pre-download size reduction on Genshin Impact (EN+JP VO) from 15.97 GB with Sophon Chunk to 5.92 GB (almost a third of the size). Pretty good work on HoYo side, but we observed only a few of HoYoplay users have them. With our implementation, everyone can use them! (As long as it's provided in the game's update data from HoYo). You can also disable them the same way as you disable the Sophon Chunk method.
[TODO: Image]
Other changes:
Templates
Changelog Prefixes