-
Notifications
You must be signed in to change notification settings - Fork 59
Add clang-tidy CI workflow #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
47a2951
to
af5e7f9
Compare
@HanatoK Continuing the conversation here, one of the advantages of using a container is to use a recent version of the Clang tools. The |
With the downgrade from Clang 20 to 18 and removal of the Lepton sources, we are down to two issues, one with I have a good idea about how to fix the former (requires some small refactoring) but I'm puzzled by the latter: I though that having added the |
Looks like the checks are the same between 18 and 20, but good to have the latter back for the future (thanks @HanatoK). I would like to add support for GNU Parallel in |
That's a good idea, but I don't know how to parallelize the script with GNU Parallel. It looks like there are other ways to parallelize the executions as well (see https://stackoverflow.com/questions/38774355/how-to-parallelize-for-loop-in-bash-limiting-number-of-processes). |
f9c6421
to
d245519
Compare
I had forgotten about Also restored the |
Also tidy up an unneeded line
This commit should fix the clang-tidy warning.
This commit uses a shell script to run clang-tidy only over the Colvars source files, which could skip the Lepton source files. This commit also avoids pulling the apptainer image.
64f09ec
to
ae99b67
Compare
In draft for now: even with the default settings, the current code does not pass the test.