-
Notifications
You must be signed in to change notification settings - Fork 61
Deprecate "enableFitGradients no" #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Looking at this, I wonder if we could just switch this flag on for all functional tests. That would be simpler. |
Honestly I don't know what to do with |
|
Yes, I'm in favor of removing it from the tests and regenerating all reference data that requires it. We don't need to remove the keyword entirely. We can deprecate it by removing its entry from the documentation and adding a release note, e.g. on a dedicated Wiki page. So we won't break anyone's workflow, but we will simplify the work of new users who won't have to think about it. |
998958a to
2691805
Compare
|
I'm still favorable to deprecating the keyword and testing only the fit gradient case. |
|
Hi @jhenin and @giacomofiorin ! Should I regenerate the test data without |
|
I would use this PR, for simplicity. You can change the title. |
OK. I have changed the title and added a list of TODOs. |
This PR aims to complete #850 by adding the tests at first.
However, I was not quite sure how to add new tests with only
enableFitGradientschanged toyes, so I copied the files intoinput_filesmanually. Please let me know if you have a better idea to change the test files while keeping the oldenableFitGradients noconfiguration for the time being.Update:
For the time being, in commit 2691805, I have added a warning for
enableFitGradients no.Tasks:
enableFitGradients nofrom the stub tests;