Refactoring of affiliations page #1957
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| desc 'get affiliations' | ||
| get 'all' do | ||
| u_affiliation_ids = UserAffiliation.where(user_id: current_user.id).pluck(:affiliation_id) |
There was a problem hiding this comment.
Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
| desc 'get affiliations' | ||
| get 'all' do | ||
| u_affiliation_ids = UserAffiliation.where(user_id: current_user.id).pluck(:affiliation_id) | ||
| @u_affiliations = Affiliation.where(id: u_affiliation_ids).select(:id, :country, :organization, :department, :group, :from, :to).order( |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [144/120]
| get 'all' do | ||
| u_affiliation_ids = UserAffiliation.where(user_id: current_user.id).pluck(:affiliation_id) | ||
| @u_affiliations = Affiliation.where(id: u_affiliation_ids).select(:id, :country, :organization, :department, :group, :from, :to).order( | ||
| to: :desc, from: :desc, created_at: :desc) |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [186/120]
| get 'all' do | ||
| u_affiliation_ids = UserAffiliation.where(user_id: current_user.id).pluck(:affiliation_id) | ||
| @u_affiliations = Affiliation.where(id: u_affiliation_ids).select(:id, :country, :organization, :department, :group, :from, :to).order( | ||
| to: :desc, from: :desc, created_at: :desc) |
There was a problem hiding this comment.
Layout/FirstArgumentIndentation: Indent the first argument one step more than the start of the previous line.
| get 'all' do | ||
| u_affiliation_ids = UserAffiliation.where(user_id: current_user.id).pluck(:affiliation_id) | ||
| @u_affiliations = Affiliation.where(id: u_affiliation_ids).select(:id, :country, :organization, :department, :group, :from, :to).order( | ||
| to: :desc, from: :desc, created_at: :desc) |
There was a problem hiding this comment.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
| end | ||
| put 'update' do | ||
| attributes = declared(params, include_missing: false) | ||
| Affiliation.find_by_id(params[:id])&.update_columns(attributes) |
There was a problem hiding this comment.
Rails/DynamicFindBy: Use find_by instead of dynamic find_by_id.
| end | ||
| put 'update' do | ||
| attributes = declared(params, include_missing: false) | ||
| Affiliation.find_by_id(params[:id])&.update_columns(attributes) |
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_columns because it skips validations.
| status 204 | ||
| body false | ||
| rescue ActiveRecord::RecordInvalid => e | ||
| error!({ error: e.message }, 422) |
There was a problem hiding this comment.
Layout/IndentationWidth: Use 2 (not 3) spaces for indentation.
| status 204 | ||
| body false | ||
| rescue ActiveRecord::RecordInvalid => e | ||
| error!({ error: e.message }, 422) |
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
LCOV of commit
|
Refactor affiliations page using React.
Move public apis related to affiliations to affiliations_api