Remove prevSelectedPosition state
#3627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3627 +/- ##
==========================================
- Coverage 93.29% 90.12% -3.17%
==========================================
Files 48 48
Lines 3458 3453 -5
Branches 697 660 -37
==========================================
- Hits 3226 3112 -114
- Misses 232 341 +109
|
amanmahajan7
changed the title
prevSelectedPosition state and one useLayoutEffectprevSelectedPosition state
nstepien
approved these changes
Nov 12, 2024
amanmahajan7
commented
Nov 12, 2024
| useLayoutEffect(() => { | ||
| if ( | ||
| !selectedCellIsWithinSelectionBounds || | ||
| isSamePosition(selectedPosition, prevSelectedPosition) |
Collaborator
Author
There was a problem hiding this comment.
It does not look like check is needed
Collaborator
Author
There was a problem hiding this comment.
Forgot to post this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.