-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Migrate remaining tests to vitest-browser-react and browserUserEvent
#3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
1d84213
Start migrating remaining tests
amanmahajan7 120e395
-1
amanmahajan7 1027683
-1
amanmahajan7 b0e701d
-1
amanmahajan7 f4a79b7
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 447d85e
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 2a21212
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 0a6ca5e
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 48a6016
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 259d83b
Save changes
amanmahajan7 7c5c7dc
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 8d8ca91
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 1d1218b
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 fa1c707
Migrate remaining tests
amanmahajan7 efa80cf
-1
amanmahajan7 49b6d0e
revert `getCellsAtRowIndex`
amanmahajan7 3e15758
Remove `@testing-library/react` usage
amanmahajan7 403f1d6
Uninstall testing-library
amanmahajan7 1f30662
- async
amanmahajan7 f13252a
Import browser userEvent
amanmahajan7 ad9d7a3
Fix scroll
amanmahajan7 8dfd131
Install `@testing-library/dom`
amanmahajan7 e06fdac
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 dfd9294
-1
amanmahajan7 b9235f5
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 5a16b94
Fix last test
amanmahajan7 cf2ab47
Add back `userEvent` for consistency
amanmahajan7 381d5a5
Merge branch 'main' into am-migrate-remaining-tests
amanmahajan7 8042334
uninstall @testing-library/dom
nstepien 0df0bad
Address comments
amanmahajan7 faf38b4
Check if selected cell has focus
amanmahajan7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build fails without it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an explicit dependency of
@vitest/browser, might be a recent change