Fix cannot open groupNodes menu from canvas (#1980)

* Fix cannot open groupNode menu from canvas * Fix cannot open groupNode menu from canvas Fixes root cause of issue * Update release.yaml with core/1.5 branch
Comfy-Org · Dec 18, 2024 · 0ce66e9 · 0ce66e9
1 parent 22f9ad3
commit 0ce66e9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -6,6 +6,7 @@ on:
     branches:
       - main
       - master
+      - core/1.5
     paths:
       - "package.json"
 

diff --git a/src/extensions/core/groupNode.ts b/src/extensions/core/groupNode.ts
@@ -1425,7 +1425,7 @@ function addConvertToGroupOptions() {
     options.splice(index + 1, null, {
       content: `Manage Group Nodes`,
       disabled,
-      callback: manageGroupNodes
+      callback: () => manageGroupNodes()
     })
   }
 

diff --git a/src/extensions/core/groupNodeManage.ts b/src/extensions/core/groupNodeManage.ts
@@ -373,7 +373,7 @@ export class ManageGroupDialog extends ComfyDialog<HTMLDialogElement> {
           groupNodes.map((g) =>
             $el('option', {
               textContent: g,
-              selected: `${PREFIX}${SEPARATOR}` + g === type,
+              selected: `${PREFIX}${SEPARATOR}${g}` === type,
               value: g
             })
           )
@@ -512,7 +512,8 @@ export class ManageGroupDialog extends ComfyDialog<HTMLDialogElement> {
     this.element.replaceChildren(outer)
     this.changeGroup(
       type
-        ? groupNodes.find((g) => `${PREFIX}${SEPARATOR}` + g === type)
+        ? groupNodes.find((g) => `${PREFIX}${SEPARATOR}${g}` === type) ??
+            groupNodes[0]
         : groupNodes[0]
     )
     this.element.showModal()
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,7 @@ on: @@
         branches:
           - main
           - master
+          - core/1.5
         paths:
           - "package.json"
@@ Expand Down @@