Relands "Fix node searchbox default value setting" (#152)

* Revert "Revert "Fix node searchbox default value setting (#150)" (#151)" This reverts commit bb02f93. * Update test expectations [skip ci] --------- Co-authored-by: github-actions <[email protected]>
Comfy-Org · Jul 18, 2024 · 54246d3 · 54246d3
1 parent bb02f93
commit 54246d3
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/...ts/interaction.spec.ts-snapshots/disconnected-edge-with-menu-chromium-linux.png b/...ts/interaction.spec.ts-snapshots/disconnected-edge-with-menu-chromium-linux.png
diff --git a/browser_tests/nodeSearchBox.spec.ts b/browser_tests/nodeSearchBox.spec.ts
@@ -1,17 +1,6 @@
 import { expect } from "@playwright/test";
-import { ComfyPage, comfyPageFixture } from "./ComfyPage";
+import { comfyPageFixture as test} from "./ComfyPage";
 
-export const test = comfyPageFixture.extend<{ comfyPage: ComfyPage }>({
-  comfyPage: async ({ comfyPage }, use) => {
-    await comfyPage.page.evaluate(async () => {
-      await window["app"].ui.settings.setSettingValueAsync(
-        "Comfy.NodeSearchBoxImpl",
-        "default"
-      );
-    });
-    await use(comfyPage);
-  },
-});
 
 test.describe("Node search box", () => {
   test("Can trigger on empty canvas double click", async ({ comfyPage }) => {

diff --git a/src/scripts/ui.ts b/src/scripts/ui.ts
@@ -429,9 +429,9 @@ export class ComfyUI {
       options: ["default", "litegraph (legacy)"],
       defaultValue: "default",
       onChange: (value?: string) => {
-        if (value === undefined) return;
         if (!app.canvas) return;
 
+        value = value || "default";
         const useLitegraphSearch = value === "litegraph (legacy)";
         app.canvas.allow_searchbox = useLitegraphSearch;
         document.dispatchEvent(