[litegraph] Fix slider value display when custom widget label is pres…

…ent (#1915) * Update litegraph * Add playwright test * Update locales [skip ci] * Update test expectations [skip ci] --------- Co-authored-by: github-actions <[email protected]>
Comfy-Org · Dec 15, 2024 · 9258098 · 9258098
1 parent fa48fe5
commit 9258098
Show file tree

Hide file tree

Showing 11 changed files with 98 additions and 5 deletions.
diff --git a/browser_tests/assets/simple_slider.json b/browser_tests/assets/simple_slider.json
@@ -0,0 +1,49 @@
+{
+  "last_node_id": 12,
+  "last_link_id": 9,
+  "nodes": [
+    {
+      "id": 12,
+      "type": "DevToolsSimpleSlider",
+      "pos": [
+        50,
+        50
+      ],
+      "size": [
+        315,
+        58
+      ],
+      "flags": {},
+      "order": 0,
+      "mode": 0,
+      "inputs": [],
+      "outputs": [
+        {
+          "name": "FLOAT",
+          "type": "FLOAT",
+          "links": null,
+          "label": "FLOAT"
+        }
+      ],
+      "properties": {
+        "Node name for S&R": "DevToolsSimpleSlider"
+      },
+      "widgets_values": [
+        0.5
+      ]
+    }
+  ],
+  "links": [],
+  "groups": [],
+  "config": {},
+  "extra": {
+    "ds": {
+      "scale": 1,
+      "offset": [
+        0,
+        0
+      ]
+    }
+  },
+  "version": 0.4
+}
diff --git a/browser_tests/nodeDisplay.spec.ts b/browser_tests/nodeDisplay.spec.ts
@@ -48,4 +48,8 @@ test.describe('Optional input', () => {
     expect(vaeInput.link).toBeNull()
     expect(convertedInput.link).not.toBeNull()
   })
+  test('slider', async ({ comfyPage }) => {
+    await comfyPage.loadWorkflow('simple_slider')
+    await expect(comfyPage.canvas).toHaveScreenshot('simple_slider.png')
+  })
 })
diff --git a/browser_tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-2x-linux.png b/browser_tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-2x-linux.png
diff --git a/browser_tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-linux.png b/browser_tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-linux.png
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -83,7 +83,7 @@
   "dependencies": {
     "@atlaskit/pragmatic-drag-and-drop": "^1.3.1",
     "@comfyorg/comfyui-electron-types": "^0.3.32",
-    "@comfyorg/litegraph": "^0.8.45",
+    "@comfyorg/litegraph": "^0.8.46",
     "@primevue/themes": "^4.0.5",
     "@vueuse/core": "^11.0.0",
     "@xterm/addon-fit": "^0.10.0",

diff --git a/src/locales/en/nodeDefs.json b/src/locales/en/nodeDefs.json
@@ -1081,6 +1081,14 @@
       }
     }
   },
+  "DevToolsSimpleSlider": {
+    "display_name": "Simple Slider",
+    "inputs": {
+      "value": {
+        "name": "value"
+      }
+    }
+  },
   "DiffControlNetLoader": {
     "display_name": "Load ControlNet Model (diff)",
     "inputs": {

diff --git a/src/locales/ja/nodeDefs.json b/src/locales/ja/nodeDefs.json
@@ -1081,6 +1081,14 @@
       }
     }
   },
+  "DevToolsSimpleSlider": {
+    "display_name": "シンプルスライダー",
+    "inputs": {
+      "value": {
+        "name": "値"
+      }
+    }
+  },
   "DiffControlNetLoader": {
     "display_name": "ControlNetモデルを読み込む（diff）",
     "inputs": {

diff --git a/src/locales/ko/nodeDefs.json b/src/locales/ko/nodeDefs.json
@@ -1081,6 +1081,14 @@
       }
     }
   },
+  "DevToolsSimpleSlider": {
+    "display_name": "간단한 슬라이더",
+    "inputs": {
+      "value": {
+        "name": "값"
+      }
+    }
+  },
   "DiffControlNetLoader": {
     "display_name": "컨트롤넷 모델 로드 (차이)",
     "inputs": {

diff --git a/src/locales/ru/nodeDefs.json b/src/locales/ru/nodeDefs.json
@@ -1081,6 +1081,14 @@
       }
     }
   },
+  "DevToolsSimpleSlider": {
+    "display_name": "Простой Слайдер",
+    "inputs": {
+      "value": {
+        "name": "значение"
+      }
+    }
+  },
   "DiffControlNetLoader": {
     "display_name": "Загрузить модель ControlNet (дифф)",
     "inputs": {

diff --git a/src/locales/zh/nodeDefs.json b/src/locales/zh/nodeDefs.json
@@ -1081,6 +1081,14 @@
       }
     }
   },
+  "DevToolsSimpleSlider": {
+    "display_name": "简单滑块",
+    "inputs": {
+      "value": {
+        "name": "值"
+      }
+    }
+  },
   "DiffControlNetLoader": {
     "display_name": "加载控制网模型（diff）",
     "inputs": {