Skip to content

Commit

Permalink
Mark app.showMissingNodeDialog private (#1210)
Browse files Browse the repository at this point in the history
  • Loading branch information
huchenlei authored Oct 10, 2024
1 parent ec8e6f7 commit f643659
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/scripts/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2174,7 +2174,7 @@ export class ComfyApp {
localStorage.setItem('litegrapheditor_clipboard', old)
}

showMissingNodesError(missingNodeTypes, hasAddedNodes = true) {
#showMissingNodesError(missingNodeTypes, hasAddedNodes = true) {
if (useSettingStore().get('Comfy.Workflow.ShowMissingNodesWarning')) {
showLoadWorkflowWarning({
missingNodeTypes,
Expand All @@ -2187,7 +2187,7 @@ export class ComfyApp {
})
}

showMissingModelsError(missingModels, paths) {
#showMissingModelsError(missingModels, paths) {
if (useSettingStore().get('Comfy.Workflow.ShowMissingModelsWarning')) {
showMissingModelsWarning({
missingModels,
Expand Down Expand Up @@ -2416,11 +2416,11 @@ export class ComfyApp {

// TODO: Properly handle if both nodes and models are missing (sequential dialogs?)
if (missingNodeTypes.length && showMissingNodesDialog) {
this.showMissingNodesError(missingNodeTypes)
this.#showMissingNodesError(missingNodeTypes)
}
if (missingModels.length && showMissingModelsDialog) {
const paths = await api.getFolderPaths()
this.showMissingModelsError(missingModels, paths)
this.#showMissingModelsError(missingModels, paths)
}
await this.#invokeExtensionsAsync('afterConfigureGraph', missingNodeTypes)
requestAnimationFrame(() => {
Expand Down Expand Up @@ -2798,7 +2798,7 @@ export class ComfyApp {
(n) => !LiteGraph.registered_node_types[n.class_type]
)
if (missingNodeTypes.length) {
this.showMissingNodesError(
this.#showMissingNodesError(
// @ts-expect-error
missingNodeTypes.map((t) => t.class_type),
false
Expand Down

0 comments on commit f643659

Please sign in to comment.