Show dropped image in output node #1150
Open
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- blobUrl is an optional paramtere in loadGraphData - sets the preview image on SaveImage and PreviewImage nodes - works for any dropped png or webp, also from the queue
|
See #497 (comment) This solution has a few missing parts:
|
…image_in_output_node
- The file is displayed only on the node it was saved by. - No longer restricted to specific supported node types
|
Thanks for your review @huchenlei. Here's a task list based on the discussed:
Persisting the queue history would be a way bigger task so I'm going with your 2nd suggestion ("single asset that has workflow as metadata back to correct output node") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #497 feature request.
Implementation details:
all SaveImage nodesthe original node it was saved byoutput_node_idmetadata when presentFor reviewers: