Skip to content

Commit

Permalink
unique artifact ids all over
Browse files Browse the repository at this point in the history
  • Loading branch information
mcmonkey4eva committed Jul 20, 2024
1 parent 9c726f4 commit a861973
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion action.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def main(args):
counter = 1

for workflow_file_name in workflow_files:
gs_path = make_unix_safe(f"output-files/{args.github_action_workflow_name}-{args.os}-{args.python_version}-{args.cuda_version}-{workflow_file_name}-run-{args.run_id}")
gs_path = make_unix_safe(f"output-files/{args.github_action_workflow_name}-{args.os}-{args.python_version}-{args.cuda_version}-{args.torch_version}-{workflow_file_name}-run-{args.run_id}")
send_payload_to_api(args, gs_path, workflow_file_name, 0, 0, WfRunStatus.Started)
# Construct the file path
file_path = f"workflows/{workflow_file_name}"
Expand Down
12 changes: 6 additions & 6 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ runs:
uses: actions/upload-artifact@v4
if: ${{ inputs.os != 'windows' && ( success() || failure() ) }}
with:
name: output-files-${{ github.job }}-${{ inputs.os }}-${{inputs.workflow_name}}-torch-${{inputs.torch_version}}-${{inputs.cuda_version}}-${{ github.run_id }}
name: output-files-${{ github.job }}-${{ inputs.os }}-${{ inputs.python_version }}-${{ inputs.cuda_version }}-${{ inputs.torch_version }}-${{ inputs.workflow_name }}-run${{ github.run_id }}
path: ${{ github.workspace }}/output/**

- name: '[Unix] Upload log file to GCS'
Expand All @@ -260,13 +260,13 @@ runs:
uses: google-github-actions/upload-cloud-storage@v2
with:
path: ${{ github.workspace }}/application.log
destination: ${{ inputs.gcs_bucket_name }}/logs/${{ github.job }}-${{ inputs.os }}-${{ inputs.workflow_name }}-run${{ github.run_id }}
destination: ${{ inputs.gcs_bucket_name }}/logs/${{ github.job }}-${{ inputs.os }}-${{ inputs.python_version }}-${{ inputs.cuda_version }}-${{ inputs.torch_version }}-${{ inputs.workflow_name }}-run${{ github.run_id }}

- name: '[Unix] Upload log file'
if: ${{ inputs.os != 'windows' && ( success() || failure() ) }}
uses: actions/upload-artifact@v4
with:
name: app-logs-${{ github.job }}-${{ inputs.os }}-${{inputs.workflow_name}}-torch-${{inputs.torch_version}}-${{inputs.cuda_version}}-${{ github.run_id }}
name: app-logs-${{ github.job }}-${{ inputs.os }}-${{ inputs.python_version }}-${{ inputs.cuda_version }}-${{ inputs.torch_version }}-${{ inputs.workflow_name }}-run${{ github.run_id }}
path: ${{ github.workspace }}/application.log

- name: '[Unix] Cleanup output files only'
Expand Down Expand Up @@ -454,7 +454,7 @@ runs:
uses: actions/upload-artifact@v4
if: ${{ inputs.os == 'windows' && ( success() || failure() ) }}
with:
name: output-files-${{ github.job }}-${{ inputs.os }}-${{inputs.workflow_name}}-torch-${{inputs.torch_version}}-${{inputs.cuda_version}}-${{ github.run_id }}
name: output-files-${{ github.job }}-${{ inputs.os }}-${{ inputs.python_version }}-${{ inputs.cuda_version }}-${{ inputs.torch_version }}-${{ inputs.workflow_name }}-run${{ github.run_id }}
path: ${{ github.workspace }}/output/**

- name: '[Win] Upload log file to GCS'
Expand All @@ -463,13 +463,13 @@ runs:
uses: google-github-actions/upload-cloud-storage@v2
with:
path: ${{ github.workspace }}/application.log
destination: ${{ inputs.gcs_bucket_name }}/logs/${{ github.job }}-${{ inputs.os }}-${{ inputs.workflow_name }}-run${{ github.run_id }}
destination: ${{ inputs.gcs_bucket_name }}/logs/${{ github.job }}-${{ inputs.os }}-${{ inputs.python_version }}-${{ inputs.cuda_version }}-${{ inputs.torch_version }}-${{ inputs.workflow_name }}-run${{ github.run_id }}

- name: '[Win] Upload log file'
uses: actions/upload-artifact@v4
if: ${{ inputs.os == 'windows' && ( success() || failure() ) }}
with:
name: app-logs-${{ github.job }}-${{ inputs.os }}-${{inputs.workflow_name}}-torch-${{inputs.torch_version}}-${{inputs.cuda_version}}-${{ github.run_id }}
name: app-logs-${{ github.job }}-${{ inputs.os }}-${{ inputs.python_version }}-${{ inputs.cuda_version }}-${{ inputs.torch_version }}-${{ inputs.workflow_name }}-run${{ github.run_id }}
path: ${{ github.workspace }}/application.log

# - name: '[Win] Sleep for 10 minutes on failure'
Expand Down

0 comments on commit a861973

Please sign in to comment.