Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix state leakage between unit tests #978

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Feb 22, 2025

  • Unit tests are now isolated by performing a full reset of all mocks.
  • Default mocks are now added using the proper default mock syntax, rather than adding a resettable mock at the start of a file.

┆Issue is synchronized with this Notion page by Unito

- Unit tests are now isolated by performing a full reset of all mocks.
- Default mocks are now added using the proper default mock syntax, rather than adding a resettable mock at the start of a file.
@webfiltered webfiltered requested review from a team as code owners February 22, 2025 01:30
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 22, 2025
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this preferred pattern of mocking to cursor rules?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 22, 2025
@webfiltered
Copy link
Contributor Author

Should we add this preferred pattern of mocking to cursor rules?

Almost did - thought I'd wait and see if the @links to files make it "just work" first. But I need a break from this hah.

@webfiltered webfiltered merged commit b20f20a into main Feb 22, 2025
7 checks passed
@webfiltered webfiltered deleted the state-leakage branch February 22, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants