[WIP] Feat: Add quick install button in NodeDetails.tsx #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎨 Chromatic Visual Testing Results
Check the visual changes and approve or request changes as needed. |
Co-authored-by: snomiao <[email protected]>
Copilot stopped work on behalf of
snomiao due to an error
July 23, 2025 09:56
🎨 Chromatic Visual Testing Results
Check the visual changes and approve or request changes as needed. |
Resolved conflicts in locale files by keeping both sets of translations.
- Add modal warning before navigating to comfy:// protocol URL - Warn users they need latest ComfyUI Desktop with comfy-cli installed - Add translation keys for warning modal in all supported languages - Users must confirm before proceeding with Quick Install Fixes issue where users without latest ComfyUI Desktop may be confused when Quick Install button doesn't work as expected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Merged latest changes from main including: - Storybook restructuring - Dark theme fixes - GitHub Actions workflow updates - Turkish language support Resolved merge conflicts in locale files by: - Accepting main's sorted locale structure - Re-adding Quick Install feature translations for all languages 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Resolved conflicts in: - components/nodes/NodeDetails.tsx: kept Quick Install feature from current branch - locale files: kept our translations with Quick Install support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Install Button Implementation ✅
Successfully implemented the Quick Install button feature for NodeDetails.tsx with the following specifications:
Key Features:
comfy://install-custom-node/:nodeIdin a new windowTechnical Implementation:
window.open()with timeout-based fallback detectionTesting Results:
Demo Screenshot:
The implementation follows the issue requirements exactly and maintains backward compatibility while adding the new functionality seamlessly.
Fixes #182.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.