Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated preview/refine functions and update docstrings #25

Merged
merged 3 commits into from
Mar 20, 2025
Merged

remove deprecated preview/refine functions and update docstrings #25

merged 3 commits into from
Mar 20, 2025

Conversation

rfeinman
Copy link
Collaborator

@rfeinman rfeinman commented Mar 20, 2025 •
edited
Loading

This PR implements the following changes:

  1. remove get_3d_refine() and get_3d_preview() methods from BackendClient class
  2. update function docstrings to explain the additional arguments (passed via **kwargs). Point to the REST API docs for the details
  3. remove explicit argument defs for pivot_point and scaled_bbox

@rfeinman rfeinman requested a review from dmitrydubovoy March 20, 2025 14:27
@rfeinman
Copy link
Collaborator Author

rfeinman commented Mar 20, 2025 •
edited
Loading

Note: I have not yet implemented items 2 & 3 (only 1 so far). Working on it

@rfeinman
Copy link
Collaborator Author

rfeinman commented Mar 20, 2025 •
edited
Loading

Have now completed 1, 2 & 3

@rfeinman rfeinman requested a review from elaidlaw March 20, 2025 14:50
@rfeinman rfeinman merged commit 3013714 into main Mar 20, 2025
@rfeinman rfeinman deleted the updates-mar20 branch March 20, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elaidlaw elaidlaw elaidlaw approved these changes

@dmitrydubovoy dmitrydubovoy Awaiting requested review from dmitrydubovoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfeinman @elaidlaw