Remove Development environments check from otel collector
#869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a guard for `IsRunMode`, so there's no need to further restrict to just Development environments. Fixes CommunityToolkit#857.
martinjt
approved these changes
Sep 23, 2025
|
@martinjt as the code owner, feel free to merge the PR's in |
This was referenced Sep 26, 2025
FullStackChef
pushed a commit
to FullStackChef/CommunityToolkit-Aspire
that referenced
this pull request
Sep 26, 2025
…yToolkit#869) There is already a guard for `IsRunMode`, so there's no need to further restrict to just Development environments. Fixes CommunityToolkit#857.
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #857
The
IsDevelopmentenvironment check when adding dev certs is a bit excessive - there is already aIsRunModeguard to protect against injecting dev certs in published environments.PR Checklist
limit, so don't push entire description over that)
Other information