-
Notifications
You must be signed in to change notification settings - Fork 80
WrapPanel2 Component Creation #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Demo Video StretchPanel-Demo1.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Avid29, great start! I just dropping a couple of quick comments.
There's a few option combinations/scenarios that I may be a bit confused on still with how stretching works, maybe it has to do when both children in a row have a specific fixed size, as it's weird to see them not always be that fixed size. Though I know the video is a little out-of-date too, so not sure if that's a factor.
Not sure if it needs to be part of the doc or some other aspect, but I think it'll be good for us to enumerate a bunch of various settings and scenarios and how we expect their behavior to react to layout and see how that matches up with our expectations on various settings and such. Then we can encode those results in the docs/examples/tests.
(This can be an ongoing process too, as we gather feedback.)
| When not stretched along the main axis, star-sized child elements will be the smallest size possible while maintaining proportional sizing relative to each other and ensuring that all child elements are fully visible. | ||
|
|
||
|
|
||
| > [!Sample WrapPanel2BasicSample] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking it could be good to also split out some more dedicated smaller/fixed examples that show interesting/dedicated uses. The uber example is fun to play with, but I think makes it hard to understand where to use each type of functionality.
i.e. the idea is that the panel is flexible to use in a variety of scenarios, but it'd be rare to try and use every aspect at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. I'll change the "Basic Sample" page to "Basic Samples" and make the current sample a "Mega Sample" page.


Introduces the first draft of the
WrapPanel2.Resolves: #763 as discussed in #762.