Fix Media Element Full Screen in Windows when using Multiple Windows #2506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Window` for grabbing correct window in multi-window environment
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where MediaElement full screen mode doesn't work correctly when multiple windows are active on Windows. The fix changes how the app window is identified for full screen operations by using the foreground window instead of the current page's window.
- Replaces static app window caching with dynamic foreground window detection
- Uses Windows API
GetForegroundWindow()to identify the correct window for full screen operations - Enables unsafe blocks in the project to support P/Invoke calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MauiMediaElement.windows.cs | Implements P/Invoke to GetForegroundWindow and updates window detection logic |
| CommunityToolkit.Maui.MediaElement.csproj | Enables unsafe blocks to support P/Invoke functionality |
src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.windows.cs
Show resolved
Hide resolved
src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.windows.cs
Outdated
Show resolved
Hide resolved
…windows.cs Co-authored-by: Copilot <[email protected]>
…)` and if it is null throw InvalidOperationException if window is null.
dotnet-policy-service
bot
added
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix window behavior when entering full screen mode while you have mulitple windows active.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR2025-02-10.06-44-08.mp4