Camera Video Recording #2710
Open
Camera Video Recording #2710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
reviewed
Jun 12, 2025
There was a problem hiding this comment.
@VladislavAntonyuk I believe you're using the old Camera2 APi, you should use the CameraX API instead, it will be simpler and it's newer
here for reference https://developer.android.com/media/camera/camerax/video-capture
I see we reference a NuGet for camera 2, that is why I used this implementation. According to Google camera 2 is not obsolete, but allows you to have a full control of the camera. CameraX just a convenient way to work with camera api. I will update to CameraX. |
Ensures proper handling of the video recording stream by setting appropriate file access and share options. Also, explicitly flushes the stream and nullifies the file after copying to prevent potential issues with file access or deletion. Addresses an issue where the `VideoRecordEvent` was not correctly identified as the final event.
Updates the `PlatformStartVideoRecording` method signature on Tizen to accept a stream, allowing for greater flexibility in handling video data.
Updated CameraViewPage.xaml to include buttons for starting/stopping video recording and setting night mode. Changed "GetStream" button text to "Save Video Recording" and repositioned "Capture Image" button. Simplified video file creation in CameraManager.android.cs by removing unnecessary ContentValues. Modified PlatformStopVideoRecording to change flow after stopping video recording. Enhanced CreateStopVideoRecordingCommand to use async lambda for better asynchronous operation handling.
…ommunityToolkit/Maui into feature/camera-video-recording
ne0rrmatrix
reviewed
Jul 21, 2025
ne0rrmatrix
reviewed
Jul 21, 2025
ne0rrmatrix
reviewed
Jul 21, 2025
ne0rrmatrix
reviewed
Jul 21, 2025
ne0rrmatrix
reviewed
Jul 21, 2025
src/CommunityToolkit.Maui.Camera/Primitives/CameraViewDefaults.shared.cs
Show resolved
Hide resolved
|
This is looking very well done! I am shocked at how nice some of the code looks. I have for over a year now wanted a solution to async - await for android in dotnet. From looking at this code I can see an easy example I can reference in the future for how to do that! Ty for that alone! I am going to test on my Mac mini and my iPad later this morning but just looking at the code it looks good to go after you look at my comments. I think all that is left for now is finishing testing and starting the documentation. This is a great addition to the toolkit. |
|
Start video recording on iOS and iOS simulator is crashing on button click with message about not finding camera. |
|
Managed to get a stacktrace for MacOS. For some reason the debugger was not working for either iOS simulator or device. MacOS: Hopefully that might help figure out what is going on. I don't have a camera attached to my mac mini. Which is probably an issue but should the sample app crash when you open the camera page? It just CTD when I navigate to camera page. |
|
The camera is not available on iOS simulators; you can only test it on real devices |
Refactor video recording logic and improve null checks - Updated `StartUseCase` in `CameraManager.android.cs` to use a builder pattern for `videoRecorder`, allowing for null checks on `Quality.Highest`. - Changed executor retrieval in `PlatformStartVideoRecording` to enhance readability and error handling. - Improved null safety in `EnableModes` by checking for nullability of `extensionsManager`. - Updated `SupportedOSPlatform` in `CameraManager.windows.cs` to require a higher minimum Windows version. - Refactored `PlatformStartVideoRecording` to use `var` for `profile` and modernized null-checking style for `frameSource` and `frameFormat`.
|
is there anything blocking this change? |
TheCodeTraveler
requested changes
Sep 7, 2025
|
Hey @TheCodeTraveler, thank you for the code review. Why did you change StartVideoRecording method to return the stream? |
| namespace CommunityToolkit.Maui.Core; | ||
|
|
||
| [SupportedOSPlatform("windows10.0.10240.0")] | ||
| [SupportedOSPlatform("windows10.0.16299.0")] |
There was a problem hiding this comment.
We should bump the .net9.0-windows version in CommunityToolkit.Maui.Camera.csproj, right?
$(NetVersion)-windows10.0.16299.0
This is basically saying that CameraView only works on Windows v10.0.16299.0+ since it requires CameraManager.
There was a problem hiding this comment.
We have version 19041; we probably can remove the attribute altogether.
This reverts commit 6be4152.
Updates the camera permission request to also request microphone permissions. This ensures that the application has the necessary permissions to record audio when capturing video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
https://vladislavantonyuk.github.io/articles/Turn-any-phone-into-an-IP-Camera-in-30-Minutes-using-.NET-MAUI/