Skip to content

Hide NavigationBar from Android popups #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide NavigationBar from Android popups #2866

wants to merge 1 commit into from

Conversation

bijington
Copy link
Contributor

@bijington bijington commented Aug 28, 2025 •
edited
Loading

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 19:01
Copilot
Copilot AI reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR hides the navigation bar from Android popups by setting the navigation bar visibility to false on popup pages. This ensures a cleaner popup presentation by removing the navigation bar that might otherwise appear on Android devices.

  • Adds navigation bar visibility control to popup pages

src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs
this.SetBinding(BackgroundColorProperty, static (IPopupOptions options) => options.PageOverlayColor, source: popupOptions, mode: BindingMode.OneWay);

Shell.SetPresentationMode(this, PresentationMode.ModalNotAnimated);
Shell.SetNavBarIsVisible(this, false);
Copy link
Preview

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a platform-specific approach since the title mentions 'Android popups' but this change affects all platforms. Use On<Android>().SetNavBarIsVisible(this, false) to target only Android, similar to how the iOS-specific code is handled on line 69.

Suggested change
Shell.SetNavBarIsVisible(this, false);
On<Android>().SetNavBarIsVisible(this, false);

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bijington - do we want to hide the Navigation Bar only on Android, or do we want to hide it on iOS too?

How does this look on iOS now compared to its previous/current implementation?

@dotnet-policy-service dotnet-policy-service bot added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCodeTraveler TheCodeTraveler TheCodeTraveler left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bijington @TheCodeTraveler