-
Notifications
You must be signed in to change notification settings - Fork 466
Fix MediaElement windows fails to playback #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…istinct number of times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the Windows implementation of MediaElement where MP4 files from URLs would fail to playback after being loaded multiple times. The fix changes how media sources are set by using the MediaPlayer API methods (SetUriSource and SetFileSource) instead of directly setting the Source property.
Key Changes:
- Replace direct
Player.Sourceassignment withPlayer.MediaPlayer.SetUriSource()for URI-based sources - Replace direct
Player.Sourceassignment withPlayer.MediaPlayer.SetFileSource()for file-based sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
[Bug Fix]
Description of Change
This changes how
Sourceis set in Windows for MediaPlayer. It currently sets source directly. Now it will set source not onPlayerbut onPlayer.MediaPlayerusing eitherSetFileSourceorSetUriSourceThis addresses the issue linked below where anmp4file in aUrlwill fail to playback after an arbitrary number of times it has been loaded.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Previous behavior
2025-10-24.17-47-14.mp4
Fixed Behavior
2025-10-24.18-03-13.mp4