Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marquee Text Control #4523

Closed
wants to merge 27 commits into from
Closed

Marquee Text Control #4523

wants to merge 27 commits into from

Conversation

Avid29
Copy link
Contributor

@Avid29 Avid29 commented Mar 23, 2022

Fixes CommunityToolkit/Labs-Windows#230

Adds a Marquee Control that scrolls contained text

PR Type

What kind of change does this PR introduce?

Feature

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 23, 2022

Thanks Avid29 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi March 23, 2022 20:29
@ghost ghost added the feature request 📬 A request for new changes to improve functionality label Mar 23, 2022
@michael-hawker michael-hawker added the labs 🧪 Marks an issue/PR involved with Toolkit Labs label Mar 23, 2022
@Arlodotexe
Copy link
Member

Holding off on review until we can move this to Toolkit Labs.

@michael-hawker
Copy link
Member

michael-hawker commented Jul 20, 2022

@Avid29 #4487 Labs is finally here! Sorry for the delays. I'll have @Arlodotexe and @LalithaNadimpalli coordinate with you a bit next week to migrate CommunityToolkit/Labs-Windows#230 to a Labs Discussion, open up a new Experiment tracking issue in Labs, and help you with anything related to the Labs template to help us test out importing your control and samples. 🎉 Thanks!

@michael-hawker
Copy link
Member

Closing this as moved to WCT Labs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 📬 A request for new changes to improve functionality labs 🧪 Marks an issue/PR involved with Toolkit Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Marquee Text Control
3 participants