Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Update/Test building of WinUI branch #4751

Closed
wants to merge 2 commits into from
Closed

Conversation

michael-hawker
Copy link
Member

The winui branch of our repo hasn't been built since last fall. This PR is the initial work to test that we can build the pipeline again to produce a hotfix release before we work to merge our forks together on top of our new infrastructure from labs where all this can be coordinated together.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Doesn't build

What is the new behavior?

Builds?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Current Updates:

  • Renewed UI Test app pfx cert
  • Tested TAEF on commandline
    • MSTest not working in VS yet (not sure if was before)
  • Changed PublishReadyToRun setting for .NET 6 to False
  • Updated to 8.0 packages of .NET Community Toolkit
  • see if runs in devops
  • Update to WindowsAppSDK 1.1.x? There are some fundamental issues with us doing this, so we may stay on 1.0.x for hotfix
  • Update test package versions (I tried but that caused issues)
  • Update TAEF package version (there's new versions of this, but haven't gotten new feed location yet)
  • Separate PR? Change min version down to 17763 - this requires our dependencies to update though

Renewed UI Test app pfx cert
Tested TAEF on commandline (MSTest not working in VS yet)
Changed PublishReadyToRun setting for .NET 6 to False
Updated to 8.0 packages of .NET Community Toolkit
@ghost
Copy link

ghost commented Sep 1, 2022

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi September 1, 2022 20:54
@michael-hawker michael-hawker deleted the winui-update branch September 1, 2022 21:01
@michael-hawker michael-hawker restored the winui-update branch October 20, 2022 06:33
@michael-hawker
Copy link
Member Author

Ugh, I forgot to point out that I re-opened this under #4752 as I had to rename the branch. That's why I deleted this one. Not sure how I didn't see the other one in the list when looking for this.

@michael-hawker michael-hawker deleted the winui-update branch October 20, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant