Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for ListDetailsView.OnListPaneWidthChanged #4817

Conversation

nodew
Copy link

@nodew nodew commented Dec 23, 2022

Fixes

When I try to use the ListPaneWidth of ListDetailsView with WinUI3/WindowsAppSDK, I got the same error described in #4357
It seems that the fix #4738 only fixed the issue in UWP and missed WinUI3

PR Type

What kind of change does this PR introduce?

Bugfix

Refactoring

What is the current behavior?

_TwoPaneView passed without checking for null

What is the new behavior?

It will check if _twoPaneView is null, and set value to _twoPaneView.Pane1Length only when it's not null.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Dec 23, 2022

Thanks nodew for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi December 23, 2022 14:37
@net-foundation-cla
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ nodew sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@net-foundation-cla
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ nodew sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3. labels Dec 23, 2022
@nodew
Copy link
Author

nodew commented Jan 5, 2023

@michael-hawker @azchohfi Could you please help review the changes?

@michael-hawker
Copy link
Member

@nodew see message here: #4800 (reply in thread)

rel/winui/7.1.2 is a release branch, so we won't directly update it with a fix like this. The winui branch never got updated with the fixes from the main branch yet due to the issues with getting it to build again in #4752.

Our plan is to fix everything forward for 8.0 as we bring things over to our maintainable infrastructure.

@nodew
Copy link
Author

nodew commented Jan 12, 2023

@michael-hawker Good to know that, thanks for the information.

@nodew nodew closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ DO NOT MERGE ⚠️ WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants