-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TokenizingTextBox] Keep text after a query is submitted #4922
base: main
Are you sure you want to change the base?
Conversation
Thanks smumovic for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@smumovic please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
@dotnet-policy-service agree |
1 similar comment
@dotnet-policy-service agree
|
Thanks @smumovic for the PR, this code has moved to our new repository https://github.com/CommunityToolkit/Windows, I've moved the issue there: CommunityToolkit/Windows#168 Will move discussion to the issue for now, as not sure on the name of the property. Interesting use-case though. |
Fixes CommunityToolkit/Windows#168
Add the ability (via a XAML bool property) to keep the typed text after a QuerySubmitted event finishes. This will make the TTB useful in an 'advanced search' scenario when the user selects tokens from a list that help narrow the search criteria to a certain sub-domain (for example to search only through a certain field or several fields if more tokens are selected).
PR Type
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently the TTB deletes the entered text after a submit is made (either by pressing enter or by selecting a proposed token).
What is the new behavior?
By adding the KeepTextAfterQuerySubmitted property to the XAML and setting it to true you can modify the behavior to keep the typed text inside the text box after submitting it. The proposed solution is backward compatible as the property defaults to "false" (behaves like it currently does).
PR Checklist
Please check if your PR fulfills the following requirements:
Other information