Implement optimization for Block#toLegacyData (Electroid#106)

Comp-MC · Dec 6, 2021 · 2e4dc54 · 2e4dc54
1 parent 603a2fc
commit 2e4dc54
Showing 1 changed file with 26 additions and 0 deletions.
diff --git a/patches/server/0207-Optimize-toLegacyData-removing-sanity-checks.patch b/patches/server/0207-Optimize-toLegacyData-removing-sanity-checks.patch
@@ -0,0 +1,26 @@
+From cd150cc85ecdde1c9484693596911180a34c7d8c Mon Sep 17 00:00:00 2001
+From: Pablete1234 <[email protected]>
+Date: Sun, 5 Dec 2021 06:18:48 +0100
+Subject: [PATCH] Optimize toLegacyData removing sanity checks
+
+
+diff --git a/src/main/java/net/minecraft/server/Block.java b/src/main/java/net/minecraft/server/Block.java
+index db09989eb..874af8a32 100644
+--- a/src/main/java/net/minecraft/server/Block.java
++++ b/src/main/java/net/minecraft/server/Block.java
+@@ -158,11 +158,7 @@ public class Block {
+     }
+
+     public int toLegacyData(IBlockData iblockdata) {
+-        if (iblockdata != null && !iblockdata.a().isEmpty()) {
+-            throw new IllegalArgumentException("Don\'t know how to convert " + iblockdata + " back into data...");
+-        } else {
+-            return 0;
+-        }
++        return 0; // Sportpaper - optimize toLegacyData removing unneeded sanity checks
+     }
+
+     public IBlockData updateState(IBlockData iblockdata, IBlockAccess iblockaccess, BlockPosition blockposition) {
+-- 
+2.32.0.windows.2
+