Add PeptideShaker import UI support for InstaNovo result files#570
Open
BioGeek wants to merge 7 commits into
Open
Add PeptideShaker import UI support for InstaNovo result files#570BioGeek wants to merge 7 commits into
BioGeek wants to merge 7 commits into
Conversation
This was referenced Jun 22, 2026
PeptideShaker required a protein sequence database throughout project creation, so de novo only results (e.g. InstaNovo) could not be imported and crashed with an NPE. De novo only projects (no FASTA) are now created at the PSM level with target/decoy FDR disabled: an empty sequence provider is used, peptides are kept without protein mapping, and FASTA summary, gene mapping, protein inference, export and report sections are skipped or guarded. Opening such projects no longer requires a database. Note: de novo projects have no target/decoy FDR; winnow-based FDR control is planned for a later PR.
Allow creating a de novo only project from the New Project dialog without selecting a FASTA file (a PSM level project is created after a confirmation), and open de novo only projects without prompting for a database.
Runs the PeptideShaker command line on InstaNovo CSV output without a FASTA and verifies that a PSM level project is created.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstaNovo is a de novo peptide sequencing tool.
This PR updates the import UI for normalized CSV output from InstaNovo v1.2.2 in three modes:
Changes
InstaNovo (.instanovo.csv, .instanovo.csv.gz)InstaNovo+ (.instanovoplus.csv, .instanovoplus.csv.gz)InstaNovo with refinement (.instanovo.refined.csv, .instanovo.refined.csv.gz)De Novo Projects Without A FASTA
PeptideShaker can now create and open de novo only projects that have no protein sequence database, so InstaNovo results can be imported directly:
FastaSummary, gene mapping, protein inference, project export and the reportDatabasefield are skipped or guarded when the FASTA is null (previously this crashed with an NPE).Commits:
Support de novo only projects without a protein database,Handle de novo only projects in the GUI.Implementation Notes
Screenshot
Tests
Ran:
mvn -Dtest=eu.isas.peptideshaker.test.fileimport.InstaNovoIdentificationFileUtilsTest,eu.isas.peptideshaker.test.cmd.PeptideShakerInstaNovoCLITest test mvn -DskipTests -Dmaven.javadoc.skip=true packagePeptideShakerInstaNovoCLITestis an end-to-end CLI integration test: it runs the PeptideShaker command line on InstaNovo CSV output with no FASTA and verifies a PSM level project is created.Merge Order
Recommended order: