Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T1574 - Fix contact parent (2/2) #1959

Closed
wants to merge 3 commits into from
Closed

T1574 - Fix contact parent (2/2) #1959

wants to merge 3 commits into from

Conversation

Prazn
Copy link
Contributor

@Prazn Prazn commented Sep 2, 2024 •
edited
Loading

follow-up of PR

@Prazn Prazn self-assigned this Sep 2, 2024
@Prazn Prazn marked this pull request as ready for review September 3, 2024 09:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ecino
ecino reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not having this change also in partner_compassion module? I don't see the point of having this in partner_communication, it is totally unrelated in my opinion.

@Prazn
Copy link
Contributor Author

Prazn commented Sep 3, 2024

Why not having this change also in partner_compassion module? I don't see the point of having this in partner_communication, it is totally unrelated in my opinion.

I agree that it makes sense to do it in partner_compassion. What I'm still not sure is should I still do it here since we are fixing something that comes from the base contacts module ? Because if let's say we decide not to use the module partner_compassion, we would not have this fix anymore.

@ecino
Copy link
Member

ecino commented Sep 12, 2024

Yes please.

@Prazn Prazn mentioned this pull request Sep 12, 2024
Merged
@Prazn
Copy link
Contributor Author

Prazn commented Sep 12, 2024

Yes please.

Alright, published new PR - CompassionCH/compassion-switzerland#1660

@ecino ecino closed this Sep 12, 2024
@Prazn Prazn deleted the nip/T1574-FixContactParent branch September 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecino ecino ecino left review comments

Assignees

@Prazn Prazn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Prazn @ecino