T1799 - Fix zoom invite Part 2 (1/2) #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logged in cases. code works, need to see if we can make it cleaner
Prazn
changed the title
|
ecino
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems that the previous PR did not fix the bug. The issue is that the user can also access the registration even if he is not logged in, so we need to handle that case as well.
Technical Aspects
We now handle two cases when registering a partner to a zoom meeting:
partner_idthat we can then use to see if he is already registeredmatch_values_to_partner(...)fromres.partner.matchto get thepartner_idand see if he is already registeredMisc
Took advantage of the changes to improve the UX a bit in the case where the user is already logged in, we use his information to pre-fill the registration form