Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP-3117: Add arm64 label to bundle CSV #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Jan 29, 2025

This commit implements support for running the Compliance Operator on
ARM64 architecture.

@openshift-ci-robot
Copy link
Collaborator

@rhmdnd: This pull request references CMP-3117 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This commit implements support for running the Compliance Operator on
ARM64 architecture.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhmdnd
Copy link
Author

rhmdnd commented Jan 29, 2025

Need to land openshift/release#61066 so that we can start running optional ARM64 CI against this PR to find out what else we need to fix.

@rhmdnd rhmdnd added this to the 1.7.0 milestone Jan 29, 2025
Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

for this one, this would make it available through OperatorHub UI?

Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BhargaviGudi
Copy link
Collaborator

Verification passed with 4.18.0-0.nightly-2025-02-18-114102 + PR #668 code

$ oc get csv compliance-operator.v1.6.0 -o=jsonpath={.metadata.labels} | jq
{
  "olm.managed": "true",
  "operatorframework.io/arch.amd64": "supported",
  "operatorframework.io/arch.arm64": "supported",
  "operatorframework.io/arch.ppc64le": "supported",
  "operatorframework.io/arch.s390x": "supported",
  "operators.coreos.com/compliance-operator.openshift-compliance": ""
}

@BhargaviGudi
Copy link
Collaborator

/label qe-approved

This commit implements support for running the Compliance Operator on
ARM64 architecture.
Copy link

openshift-ci bot commented Mar 5, 2025

New changes are detected. LGTM label has been removed.

Copy link

github-actions bot commented Mar 5, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:668-7c077b0f63394ff9037c0ba8b4376a807b67e8f0

Copy link

openshift-ci bot commented Mar 5, 2025

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-parallel-arm 7c077b0 link true /test e2e-aws-parallel-arm
ci/prow/e2e-aws-serial 7c077b0 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Author

rhmdnd commented Mar 7, 2025

This should get better once #701 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants