update ocp4 check result names #13951
Open
+24,778
−24,778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rhmdnd
commented
Sep 27, 2025
rhmdnd
commented
- Update ocp4 assertion files
- Update rhcos4 assertion files
The previous check names relied on an e2e test bundle, resulting in the each check name being prefixed with `e2e`. This prefix needs to change if you're calling the suite with different profile bundles, otherwise the assertions won't match, even though you're using the same profile. This commit updates the assertion files so that we just use the default profile bundle names, and then in the test suite we'll handle the profile bundles so the one under test is always loaded using the default names. This results in less tinkering when your testing locally, versus CI running on PRs, versus periodic CI runs (they all use the same assertion files, with the same check result names).
The previous check names relied on an e2e test bundle, resulting in the each check name being prefixed with `e2e`. This prefix needs to change if you're calling the suite with different profile bundles, otherwise the assertions won't match, even though you're using the same profile. This commit updates the assertion files so that we just use the default profile bundle names, and then in the test suite we'll handle the profile bundles so the one under test is always loaded using the default names. This results in less tinkering when your testing locally, versus CI running on PRs, versus periodic CI runs (they all use the same assertion files, with the same check result names).
rhmdnd
requested review from
matusmarhefka,
Mab879,
vojtapolasek and
jan-cerny
as code owners
|
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/packit retest-failed |
|
@rhmdnd It might have to be |
Fixed in openshift/release#69497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.