Fix controleval_metrics.py for having per product controls #14166
+80
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Type hints - Doc strings - other clean up
- Type hints - Move to /usr/bin/env - clean up variable naming
Claude code was used in part to create this commit.
Mab879
requested review from
ggbecker,
jan-cerny,
marcusburghardt and
vojtapolasek
as code owners
|
@Mab879: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jan-cerny
approved these changes
Nov 24, 2025
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I have verified that with this change the generated metrics file now contains metrices for RHEL 9 profiles that are defined using product-specific controls such as RHEL 9 CIS or RHEL 9 STIG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
controleval_metrics.pyfor having per product controlsRationale:
Fix metrics
Review Hints:
Run and check the output of
./utils/controleval_metrics.py prometheus -p fedora ocp4 rhcos4 rhel10 rhel9 rhel8 sle12 sle15 -f ./build/policies_metrics