Skip to content

Commit

Permalink
Fix minor issues spotted by linter
Browse files Browse the repository at this point in the history
  • Loading branch information
adamkewley committed Jul 4, 2024
1 parent 9558dff commit 705ec00
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/oscar/Platform/os.h
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@ namespace osc
//
// returns std::nullopt if the user doesn't select a file; otherwise, returns the user-selected save location--including the extension--if
// the user selects a location
std::optional<std::filesystem::path> promp_user_for_file_save_location_add_extension_if_necessary(
std::optional<CStringView> maybeExtension = std::nullopt,
std::optional<CStringView> maybeInitialDirectoryToOpen = std::nullopt
std::optional<std::filesystem::path> prompt_user_for_file_save_location_add_extension_if_necessary(
std::optional<CStringView> maybe_extension = std::nullopt,
std::optional<CStringView> maybe_initial_directory_to_open = std::nullopt
);


Expand Down
2 changes: 1 addition & 1 deletion tests/testoscar/Graphics/TestCamera.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ TEST(Camera, can_default_construct)
TEST(Camera, can_copy_construct)
{
const Camera camera;
const Camera copy = camera;
const Camera copy = camera; // NOLINT(performance-unnecessary-copy-initialization)
}

TEST(Camera, copied_instance_compares_equal_to_original)
Expand Down

0 comments on commit 705ec00

Please sign in to comment.