Fix do not draw mesh normals for non-triangular meshes (#792)

ComputationalBiomechanicsLab · Oct 6, 2023 · b5dcc90 · b5dcc90
1 parent b8b5afb
commit b5dcc90
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/oscar/Scene/SceneRenderer.cpp b/src/oscar/Scene/SceneRenderer.cpp
@@ -237,7 +237,10 @@ class osc::SceneRenderer::Impl final {
                 }
 
                 // if normals are requested, render the scene element via a normals geometry shader
-                if (params.drawMeshNormals)
+                //
+                // care: this only works for triangles, because normals-drawing material uses a geometry
+                //       shader that assumes triangular input (#792)
+                if (params.drawMeshNormals && dec.mesh.getTopology() == MeshTopology::Triangles)
                 {
                     Graphics::DrawMesh(dec.mesh, dec.transform, m_NormalsMaterial, m_Camera);
                 }