Fix checkpointing regression introduced by TOML PR #3978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steindev
added
bug
franzpoeschel
commented
Feb 9, 2022
| = tomlDataSources->openPMDPluginOptions; | ||
| break; | ||
| } | ||
| case ConfigurationVia::CommandLine: |
Contributor
Author
There was a problem hiding this comment.
Note that we don't need to fix the ConfigurationVia::Toml path since checkpoints cannot be configured via TOML.
franzpoeschel
force-pushed
the
fix-checkpointing-after-toml
branch
from
dae3ce1 to
56a588b
Compare
Member
|
Tested writing checkpoints with this fix and it works now. Will merge. |
steindev
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...... nothing to be seen here ........
close #3977
Bug introduced by #3720
When running a checkpoint, the openPMD plugin must not attempt to read the cmd parameter
--checkpoint.openPMD.filebecause it's not there. Instead, the--checkpoint.fileparameter is used.