openPMD plugin: Workaround BP5 attribute datatype overriding #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the openPMD plugin is affected by the same issue fixed already for the Radiation plugin in #4399.
Some further background: The way that the openPMD-api uses part of the ADIOS2 APIs is an edge case that worked so far for the older engines, but works no longer for BP5, see ornladios/ADIOS2#3413.
We'll ultimately have to solve this inside openPMD-api, but we still need to discuss how exactly (several approaches possible).
Until then, overriding the datatype of default attributes (as PIConGPU does with
setDt<float>(), has to happen before the first flush.