Refactor passed atomic data boxes check #5212
Closed
+96
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
this avoids very high to ADK rates due to BSI unbound states being still present ci: picongpu
extracts the check for passed atomic data dataBoxes to avoid code duplication ci: picongpu
BrianMarre
force-pushed
the
topic-refactorPassedAtomicDataBoxesCheck
branch
from
f146ad8
to
85cab2e
Compare
|
replaced by PR #5220 to reduce CI load |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract the check of the passed bound-free atomic data boxes to avoid code duplication
This is done in preparation for the implementation of the instant field ionization transitions.
every but the last commit belongs to the base PRs